aminghadersohi commented on code in PR #45598: URL: https://github.com/apache/superset/pull/45598#discussion_r4354120429
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -489,6 +489,25 @@ The **Custom** time range picker accepts natural language expressions alongside These expressions are evaluated at query time, so saved charts always display data relative to the current date. +### Sunburst cross-filtering + +Sunburst cross-filters use the underlying hierarchy values, not the formatted +segment labels. For time-grained temporal levels, selecting a segment filters the +entire bucket. Adaptive date formatting includes the year in month and quarter +labels to distinguish buckets across years; other grains keep their compact labels. +For supported bucket ranges, the selection replaces the target chart's Time Range +and also applies to its other temporal range filters, even on another time column. +Drill to detail retains the selected bucket within the chart's time range, including +a dataset Hours offset. Drill by filters a time-grained segment by its bucket range. +As with Time-series charts, a chart or dashboard Time Range replaces that range, and an +engine-specific grain without a fixed length matches only the start of the bucket. Review Comment: I used your suggested wording for the two Time Range exceptions and the engine-specific grain limitation. Commit: 8dcf1a62d00ee7e7fbe8d0ae45e574d675d5c108 Tests: no regression test needed for this docs-only wording change. `pre-commit run` passed; `git diff --cached --check` passed before the commit. Siblings checked: - docs/docs/using-superset/exploring-data.mdx:500 — fixed in 8dcf1a62d00ee7e7fbe8d0ae45e574d675d5c108 - superset/common/query_context_factory.py:410 — not affected: shared query behavior is unchanged; the paragraph describes its existing filter replacement - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/utils.ts:146 — not affected: Drill to detail filter construction is unchanged - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/utils.ts:173 — not affected: Drill by filter construction is unchanged - docs/docs/using-superset/using-ai-with-superset.mdx:483 — not affected: MCP hierarchy documentation makes no drill bucket guarantee Remaining: the shared QueryContextFactory behavior you described needs a separate follow-up with a granularity_sqla plus chart TEMPORAL_RANGE regression test; this commit documents the limitation rather than changing that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
