veriiix opened a new pull request, #45650: URL: https://github.com/apache/superset/pull/45650
### SUMMARY - Raise `duckdb` extra upper bound from `<2` to `<3`. - Keep `motherduck` extra on `duckdb<2`: MotherDuck supports DuckDB up to 1.5.6 only (https://motherduck.com/docs/duckdb-versions.json). - Bump `duckdb` to `2.0.0` in `requirements/development.txt` so CI tests against 2.0. - Add a test against in-memory DuckDB for reflection and date/time, decimal and null handling. `duckdb-engine` 0.17.0 has no upper bound on `duckdb`, so no driver change is needed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS pytest tests/unit_tests/db_engine_specs/test_duckdb.py Passes on `duckdb==2.0.0` and `duckdb==1.5.5`. - Before: `apache-superset[duckdb]` + `duckdb==2.0.0` is unsatisfiable. - After: `[duckdb]` resolves to 2.0.0, `[motherduck]` stays on 1.5.6. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #### SUMMARY - Raise `duckdb` extra upper bound from `<2` to `<3`. - Keep `motherduck` extra on `duckdb<2`: MotherDuck supports DuckDB up to 1.5.6 only (https://motherduck.com/docs/duckdb-versions.json). - Bump `duckdb` to `2.0.0` in `requirements/development.txt` so CI tests against 2.0. - Add a test against in-memory DuckDB for reflection and date/time, decimal and null handling. `duckdb-engine` 0.17.0 has no upper bound on `duckdb`, so no driver change is needed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS pytest tests/unit_tests/db_engine_specs/test_duckdb.py Passes on `duckdb==2.0.0` and `duckdb==1.5.5`. - Before: `apache-superset[duckdb]` + `duckdb==2.0.0` is unsatisfiable. - After: `[duckdb]` resolves to 2.0.0, `[motherduck]` stays on 1.5.6. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #45637 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
