codeant-ai-for-open-source[bot] commented on code in PR #45650: URL: https://github.com/apache/superset/pull/45650#discussion_r4355618107
########## pyproject.toml: ########## @@ -240,8 +240,10 @@ mariadb = ["apache-superset[mysql]"] monetdb = ["sqlalchemy-monetdb>=2.1.0, <3", "pymonetdb>=1.9.1, <2"] mongodb = ["pymongosql>=0.7.4, <1"] mssql = ["pymssql>=2.4.2, <3"] -# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver -motherduck = ["apache-superset[duckdb]"] +# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver. +# MotherDuck does not support DuckDB 2.x clients yet (max 1.5.6, see +# https://motherduck.com/docs/duckdb-versions.json), so keep it on <2. +motherduck = ["apache-superset[duckdb]", "duckdb<2"] Review Comment: **Suggestion:** The constraint admits DuckDB 1.x releases newer than MotherDuck’s stated 1.5.6 limit, so pip can select a client version that MotherDuck does not support. **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Api mismatch` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=650a299ec0884955b53ccbf17dcfdf18&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=650a299ec0884955b53ccbf17dcfdf18&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** pyproject.toml **Line:** 246:246 **Comment:** *Api Mismatch: The constraint admits DuckDB 1.x releases newer than MotherDuck’s stated 1.5.6 limit, so pip can select a client version that MotherDuck does not support. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45650&comment_hash=0a43a1bad87abf2ed6d2bbcb098839d4c36e803f8aee9973142b65511580b6c1&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45650&comment_hash=0a43a1bad87abf2ed6d2bbcb098839d4c36e803f8aee9973142b65511580b6c1&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
