SEPURI-SAI-KRISHNA commented on PR #45456:
URL: https://github.com/apache/superset/pull/45456#issuecomment-6501368079
Fixed as described: a `continue` after the result-format check, and the
`pass`
branch dropped. 267 pass in the file, and the new test is the only failure
with
the guard reverted.
The branch update this morning brought master's `AG_GRID_TABLE` in alongside
this branch's `AG_GRID_TABLE_VIZ_TYPE`, the same string twice, so I dropped
mine and registered under master's.
The `ParserError` needs a clean first data row. `CSV_EXPORT = {"quotechar":
"'"}` with `Doe, Jane` in row two raises `Expected 2 fields in line 3, saw
3`,
but the same cell in row one makes `read_csv` infer an index and mis-parse
without raising. The test uses the raising shape.
On nothing reading the metadata, the three candidates all check out:
`apply_column_types` reads `coltypes` but sits in the XLSX branch this viz
type
never reached, `chart_data_to_dataframe` reads `colnames`/`coltypes`/
`indexnames` off a JSON result it fetches itself (`execute.py:1463`) rather
than off an attachment, and `excel_export/workbook.py:234` reads `colnames`
without going through `apply_client_processing` at all.
`read_excel` on 100k rows by 3 columns is 3.3s here, so the same order as
your
5s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
