mikebridge commented on PR #45537: URL: https://github.com/apache/superset/pull/45537#issuecomment-6373797825
_AI-assisted reply on Mike's behalf._ @fitzee: good catch. f9152f77ee logs `requested_operation=`, so the metadata request isn't mistaken for the stage that failed. The binding-fault regressions check that neither metadata method ran, and the full error-handling test file passes (97 tests). I've also corrected the description: - The MCP and `get_compatible_*` scope is now listed path by path. - The mapper bullet says exactly which `ValueError`s become 400s. - The testing section no longer claims every metadata read is covered. #45531's summary now matches this PR's logging policy: frame locations without provider messages. Still deferred, not claimed here: - test gaps for the standalone `metrics` property and the `QueryObject.validate` dimension wrapper; - the unreachable fallback and validation mutation sites. The 5xx classification and the layer/view diagnostic context are unchanged. Query-execution logging is outside this follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
