codeant-ai-for-open-source[bot] commented on code in PR #45649: URL: https://github.com/apache/superset/pull/45649#discussion_r4365119656
########## superset/views/base.py: ########## @@ -81,6 +81,7 @@ from .utils import bootstrap_user_data, get_config_value FRONTEND_CONF_KEYS = ( + "SEMANTIC_LAYER_DOCUMENTATION_URL", Review Comment: **Suggestion:** This sends the raw configured URL to every user's bootstrap payload, exposing embedded credentials even though the UI hides links containing them. **Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9694b7de84ce4ffd98a8c709c90dbabf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9694b7de84ce4ffd98a8c709c90dbabf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/views/base.py **Line:** 84:84 **Comment:** *Security: This sends the raw configured URL to every user's bootstrap payload, exposing embedded credentials even though the UI hides links containing them. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45649&comment_hash=5e5907108f4a4b03770739a420e57491fd7f874773b8b44f55259507b5412012&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45649&comment_hash=5e5907108f4a4b03770739a420e57491fd7f874773b8b44f55259507b5412012&reaction=dislike'>๐</a> ########## superset-frontend/src/pages/DatasetList/index.tsx: ########## @@ -1630,13 +1637,38 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({ addSuccessToast={addSuccessToast} semanticView={svCurrentlyEditing} /> - <AddSemanticViewModal - show={showAddSemanticViewModal} - onHide={() => setShowAddSemanticViewModal(false)} - onSuccess={refreshData} - addDangerToast={addDangerToast} - addSuccessToast={addSuccessToast} - /> + {semanticSetup === 'view' && ( + <AddSemanticViewModal + show + onHide={() => { + setSemanticSetup('closed'); + newDatasourceButtonRef.current?.focus(); + }} + onCreateLayer={ + canCreateLayer + ? () => { + if ( + isFeatureEnabled(SEMANTIC_LAYERS_FLAG) && + findPermission('can_write', 'SemanticLayer', user?.roles) + ) { + setSemanticSetup('layer'); + } + } + : undefined + } + onSuccess={refreshData} + addDangerToast={addDangerToast} + addSuccessToast={addSuccessToast} + /> + )} + {semanticSetup === 'layer' && ( + <SemanticLayerModal + show + onHide={() => setSemanticSetup('view')} Review Comment: **Suggestion:** When creation succeeds after Cancel, its POST has committed but unmounting ignores the response; if the picker refreshed first, it stays empty until reopened. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4d579a0362fd44108bf3d22020eb1a3e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4d579a0362fd44108bf3d22020eb1a3e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/pages/DatasetList/index.tsx **Line:** 1667:1667 **Comment:** *Race Condition: When creation succeeds after Cancel, its POST has committed but unmounting ignores the response; if the picker refreshed first, it stays empty until reopened. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45649&comment_hash=307d224e323972bcfe87982960ed4c28c9d929829ae32313c93ef5b946cd1ec9&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45649&comment_hash=307d224e323972bcfe87982960ed4c28c9d929829ae32313c93ef5b946cd1ec9&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
