geido commented on code in PR #45649:
URL: https://github.com/apache/superset/pull/45649#discussion_r4387231922
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx:
##########
@@ -479,72 +532,122 @@ export default function SemanticLayerModal({
width={isTypeStep ? MODAL_STANDARD_WIDTH : MODAL_MEDIUM_WIDTH}
saveDisabled={
isTypeStep
- ? !selectedType
- : saving || clearing || !name.trim() || hasErrors
+ ? !selectedType || typeStatus !== 'success' || loading
+ : loading || saving || clearing || !name.trim() || hasErrors
}
saveText={isTypeStep ? undefined : isEditMode ? t('Save') : t('Create')}
saveLoading={saving}
- contentLoading={loading}
>
<ModalContent>
- {isTypeStep ? (
- <ModalFormField label={t('Type')}>
- <Select
- ariaLabel={t('Semantic layer type')}
- placeholder={t('Select a semantic layer type')}
- value={selectedType}
- onChange={value => setSelectedType(value as string)}
- options={types.map(type => ({
- value: type.id,
- label: type.name,
- }))}
- getPopupContainer={() => document.body}
- />
- </ModalFormField>
+ <SemanticLayerSetupHelp />
+ {loading ? (
+ <Loading />
) : (
<>
- {isEditMode && (
- <Button
- disabled={dirty || saving || clearing || refreshingSchema}
- loading={clearing}
- onClick={handleReloadMetadata}
- >
- {t('Reload metadata')}
- </Button>
+ {/* COPY-TBD: semantic setup guidance, pending product copy. */}
Review Comment:
IIUC the description still calls the copy a placeholder pending product
review. Is it final now, or would it make sense to keep this in draft until it
is, so the `COPY-TBD` notes don't land?
##########
superset/config.py:
##########
@@ -2936,6 +2936,10 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument # noq
# Send user to a link where they can read more about Superset
DOCUMENTATION_URL = None
+
+# Optional setup guide shown in the semantic layer and semantic view dialogs.
+# Use an absolute HTTP(S) URL; unset deployments show no setup-guide link.
+SEMANTIC_LAYER_DOCUMENTATION_URL: str | None = None
Review Comment:
nit: this lands between `DOCUMENTATION_URL` and
`DOCUMENTATION_TEXT`/`DOCUMENTATION_ICON`, which the navbar reads together, so
`DOCUMENTATION_TEXT` now reads like the label for the setup guide. Would it
make sense to move it below `DOCUMENTATION_ICON`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
