codeant-ai-for-open-source[bot] commented on code in PR #45680: URL: https://github.com/apache/superset/pull/45680#discussion_r4364479772
########## superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/crossFilter.ts: ########## @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + DataRecordValue, + getColumnLabel, + getTimeFormatter, + QueryFormColumn, + QueryObjectFilterClause, +} from '@superset-ui/core'; +import { GenericDataType } from '@apache-superset/core/common'; +import { NULL_STRING } from '../constants'; +import { formatSeriesName } from '../utils/series'; + +/** Matches `optionLabel` in `src/utils/common.ts`. */ +const EMPTY_STRING = '<empty string>'; + +export type WaterfallCategory = { + /** The trailing total of a chart without a breakdown. Not a data category. */ + isGrandTotal: boolean; + /** Filter the X axis only. Period totals and charts without a breakdown. */ + xOnly: boolean; + xColumn: QueryFormColumn; + xValue: DataRecordValue; + breakdownColumn?: QueryFormColumn; + breakdownValue?: DataRecordValue; +}; + +function toKeyPart(value: DataRecordValue): string | number | boolean | null { + if (value == null) { + return null; + } + if (typeof value === 'bigint') { + return value.toString(); + } Review Comment: ✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `39df3f9`. `toKeyPart` now wraps bigint values as `{ bigint: value.toString() }`, keeping them distinct from decimal strings when the selection key is serialized. <sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub> <!-- codeant-auto-resolve-reply --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
