EnxDev commented on code in PR #45680:
URL: https://github.com/apache/superset/pull/45680#discussion_r4394430650
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/transformProps.ts:
##########
@@ -373,9 +421,13 @@ export default function transformProps(
axisLabel.formatter = xAxisFormatter;
axisLabel.hideOverlap = false;
- const seriesProps: Pick<BarSeriesOption, 'type' | 'stack' | 'emphasis'> = {
+ const seriesProps: Pick<
+ BarSeriesOption,
+ 'type' | 'stack' | 'emphasis' | 'cursor'
+ > = {
type: 'bar',
stack: 'stack',
+ cursor: emitCrossFilters ? 'pointer' : 'default',
Review Comment:
Nothing pins the `'default'` side of this. The only cursor assertion is
`pointer` with cross-filtering on, so a change that always returns `pointer`
would still pass.
Worth one more assertion with `emitCrossFilters: false`, since step 7 of the
testing instructions relies on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
