shchun opened a new pull request, #45695: URL: https://github.com/apache/superset/pull/45695
### SUMMARY The previous tests removed system tags, such as `type:chart`, before rendering TagsList. As a result, they could still pass if the actual ChartList filtering regressed and started displaying system tags. This change passes unfiltered tag data through ChartList and checks the rendered result so that the tests can catch that regression. The new cases cover numeric custom tags, legacy custom tags, tags without a type, system-only tags, empty or missing tags, and truncation after filtering. TagsList retains unit coverage for sorting and truncation. Application code is unchanged. AI assistance: I used Codex to help implement, review, and validate the tests, and to translate my explanation into English. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable: tests only; no UI changes. ### TESTING INSTRUCTIONS From `superset-frontend`, run: ```bash npm run test -- --runInBand src/pages/ChartList/ChartList.listview.test.tsx src/components/TagsList/TagsList.test.tsx ``` - Both suites passed: 30 tests total, using Node 24 in a Linux Docker container. - All applicable pre-commit hooks passed, including frontend type checking, against the two staged test files in a Linux validation copy verified to match the working branch. Referenced core package declarations were built first. - Regression check: in the isolated validation copy, temporarily replacing ChartList's `tags.filter(...)` with `tags` caused four of the six new cases to fail. The production source was restored, and both suites passed again. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `TAGGING_SYSTEM`, enabled in the test mocks. - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
