SEPURI-SAI-KRISHNA commented on PR #45461: URL: https://github.com/apache/superset/pull/45461#issuecomment-6385881982
@rusackas the reversed-range case is in. You and @sadpandajoe were right that nothing proved the `ValueError` arm. I reverted each `except` on its own to check: dropping `ValueError` from the outer one at `helpers.py:2936` left all 288 tests passing, so that arm was the only unpinned one. It went in as a third case on `test_processing_time_offsets_rejects_a_bad_temporal_range` rather than a new test, since only the range and the message change. That test is the sole cover for the outer `except`, and the two failures reach it as different exceptions: `TimeRangeParseFailError` for a range the parser cannot read, a bare `ValueError` for one whose bounds are reversed. Looking at the sibling sites for the same shape found one more, which is also in. Details are on Joe's thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
