SEPURI-SAI-KRISHNA commented on code in PR #45407:
URL: https://github.com/apache/superset/pull/45407#discussion_r4367644095
##########
tests/unit_tests/utils/excel_tests.py:
##########
@@ -80,6 +80,47 @@ def test_quote_formulas() -> None:
]
+def test_quote_formulas_with_leading_whitespace() -> None:
+ """
+ Formulas are quoted even when a space, tab, or newline comes first.
+
+ Spreadsheet apps still evaluate a cell whose formula prefix is preceded by
Review Comment:
Agreed, that docstring was the claim the source docstrings had just dropped.
Reworded to match: XlsxWriter reads the formula prefix at the first character
only, so a value with whitespace in front of it is a plain string cell
whether
or not it is quoted, which makes this an export-consistency check rather
than a
guard against evaluation. The CSV writer and the streaming writer both strip
before reading the prefix, so without this the same cell goes out quoted from
two of the three paths and bare from this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
