SEPURI-SAI-KRISHNA commented on PR #45407: URL: https://github.com/apache/superset/pull/45407#issuecomment-6386308958
@rusackas you were holding on sadpandajoe's open thread being answered by me rather than by you. That answer went up on the 23rd, in the `excel.py` thread: the measured cell types say no, there is no case where the leading-whitespace form is evaluated in the XLSX output, and the `" - North"` apostrophe already ships today from both the CSV and the streaming paths, so the tradeoff is not new. Your read of it was right. One correction to that answer, which @sadpandajoe caught since: I justified it partly by saying the streaming writer never builds a formula cell because every string goes through `write_string`. That is wrong. Headers and rows go through `write_row`, which types each cell from its value, so a bare `=` does become a formula cell there, and the quote is what stops it. The whitespace half of the argument is unchanged, and that is the half this PR turns on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
