rebenitez1802 commented on PR #45698: URL: https://github.com/apache/superset/pull/45698#issuecomment-6423892809
Request changes: excluded dashboards still bypass the new error handling. All 795 unit tests passed, but two focused regression checks reproduced this gap; integration tests were not run. **🟡 Medium — Excluded dashboards still suppress failure notifications** In [`_get_tab_url()`](https://github.com/apache/superset/blob/0ed1af38a8d2b47ce03cdb02d923f27053427f14/superset/commands/report/execute.py#L983-L1001), the handler catches `DashboardAccessDeniedError`, but dashboard exclusions raise `DashboardNotFoundError`. With saved dashboard state and `ALERT_REPORT_TABS` enabled, content generation and failure notifications reach this path directly, losing the actionable denial, allowing retries, and preventing the editors’ failure email. Fix: apply the executor access check before these permalink lookups so exclusions consistently become `ReportScheduleExecutorAccessDeniedError` and trigger the plain-link fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
