sadpandajoe commented on PR #45698: URL: https://github.com/apache/superset/pull/45698#issuecomment-6425194406
Thanks for the catch, this was a real gap. `_get_url` (used by content generation and by the failure-notification link) reaches `_get_tab_url` without going through `get_dashboard_urls`, so a dashboard withheld by `EXTRA_ACCESS_QUERY_EXCLUSIONS` surfaced as an uncaught `DashboardNotFoundError` there. Fixed in 74a40cfd7b: `_get_tab_url` now runs the executor access check (including the exclusion check) before any permalink lookup, so every caller gets `ReportScheduleExecutorAccessDeniedError`. That restores the plain-link fallback in `_get_failure_notification_url` and the non-retried, logged failure with the editors' notification. Added regression tests for the failure-notification path, `_get_url` with stored dashboard state, and the non-excluded case; the report unit tests pass (1259 passed). Integration tests were not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
