rusackas opened a new pull request, #45751:
URL: https://github.com/apache/superset/pull/45751

   ### SUMMARY
   
   `DatasourceModal.pendingEdits.test.tsx`'s `test.each(['metric', 'calculated 
column'])` case has timed out past Jest's default 20s budget on at least two 
unrelated master pushes:
   
   - Run 
[40370481814](https://github.com/apache/superset/actions/runs/40370481814), on 
commit `48254b64` (`fix(ci): don't publish Hadoop web ports`)
   - Run 
[40410835505](https://github.com/apache/superset/actions/runs/40410835505), on 
commit `b7cedef3` (#45476, `fix(soft-delete): clarify archive actions and 
recovery navigation`)
   
   Both failures are the exact same case (`'metric'`), with the exact same 
`Exceeded timeout of 20000 ms for a test` error. Neither commit touches 
`DatasourceModal` or anything it depends on, which rules out a real regression 
— this is CI-load-dependent flakiness in the test itself, not a bug the two 
unrelated PRs introduced.
   
   The test does real work rather than anything pathological: a full modal 
render with two AceEditor mounts, several `userEvent` interactions, and three 
real (not fake-timer) debounce waits via `settleInputs()`. The `'metric'` case 
adds an extra expand/collapse round trip on top of that (`if (isMetric) { 
...expand row... }`), which is likely why it's consistently the slower of the 
two parameterized cases. Locally both cases complete in ~7s each; under a 
contended, sharded CI runner (6 jest shards running in parallel, each covering 
~179 suites) that occasionally pushes past 20s.
   
   This PR gives the test real headroom (40s, roughly 6x the observed local 
runtime) instead of letting CI load produce an occasional false-red build on 
unrelated PRs.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — test-only change, no UI impact.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   npx jest --runInBand 
src/components/Datasource/DatasourceModal/DatasourceModal.pendingEdits.test.tsx
   ```
   
   Both cases pass locally (~6.9s each).
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to