rusackas opened a new pull request, #45750: URL: https://github.com/apache/superset/pull/45750
### SUMMARY `docker.yml`'s `docker-build` job serializes each build preset behind a per-branch concurrency group (`cancel-in-progress: false`), to stop concurrent runs from racing on the final `master*` tag push. That setting only protects a run that's already *executing* — GitHub force-cancels any run left *queued* behind it the moment a newer one supersedes it, regardless of `cancel-in-progress`. Master gets bursty pushes, so several runs routinely pile up in the same group, and everything but the newest queued one gets cancelled — showing up as a failing red "Cancelled" check on an otherwise-fine commit instead of a clean "Skipped" one. `superset-docs-deploy.yml` already solved this for the Docs Deployment workflow (#42488) with a `check-freshness` job that runs ahead of its own concurrency group and skips cleanly when superseded, so a stale run never joins the queue in the first place. This PR ports the same pattern to `docker-build`: a new `check-freshness` job gates it on whether the commit is still its branch's tip, before it ever reaches the per-preset concurrency groups. The freshness script moves from `check-docs-deploy-freshness.sh` to `check-branch-freshness.sh` and gains a `BRANCH` env var (defaulting to `master`) so it can check release-branch pushes (`docker.yml` also triggers on e.g. `7.0`) as well, plus a `pull_request` bypass alongside the existing `workflow_dispatch` one, since a PR build has no branch tip to race against (PR staleness there is already handled correctly by `docker-build`'s own `cancel-in-progress: true` for `pull_request`). No behavior changes for actually-current runs: `docker-build`'s existing in-job "Guard against publishing a superseded master commit" step is untouched and still serves as the last line of defense for the rare case where a run passes the early freshness check but a newer one still finishes first. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — CI-only change, no UI impact. ### TESTING INSTRUCTIONS ```bash bash .github/workflows/scripts/check-branch-freshness.test.sh ``` Covers the `workflow_dispatch`/`pull_request` bypasses, current-tip, stale-tip, and explicit-`BRANCH` (release branch) cases. Also validated with `action-validator`, `actionlint`, and `pre-commit run` (including `zizmor`) against all changed workflow files. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
