codeant-ai-for-open-source[bot] commented on code in PR #45750:
URL: https://github.com/apache/superset/pull/45750#discussion_r4384058268
##########
.github/workflows/docker.yml:
##########
@@ -300,13 +339,18 @@ jobs:
docker-build:
name: docker-build
- needs: [setup_matrix, changes]
+ needs: [setup_matrix, changes, check-freshness]
# Only master pushes publish images (see scripts/docker-build-plan.sh).
# Without the Docker Hub credentials (e.g. on a fork or mirror) they can
# publish nothing, so they are skipped there. Version-branch pushes and
# pull_request builds only load the image to validate that it builds, so
- # they run everywhere.
+ # they run everywhere. check-freshness.outputs.is-current is always
+ # 'true' for pull_request (it bypasses the check there — a PR build has
+ # no branch tip to race against, and staleness is instead handled by
+ # this job's own cancel-in-progress: true below), so this only narrows
+ # push triggers superseded by a newer commit on the same branch.
if: >-
+ needs.check-freshness.outputs.is-current == 'true' &&
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> In this workflow, do not flag a Docker build skipped after a newer
docs-only push as an incomplete implementation: concurrency already cancels
superseded pending runs, and validating against the last built SHA is out of
scope.
**Applied to:**
- `.github/workflows/docker.yml`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
