rusackas commented on PR #43567: URL: https://github.com/apache/superset/pull/43567#issuecomment-6431065620
Resolved the stale threads that had already been fixed or explicitly deferred as follow-up (sort_by_metric → orderby, the CWE-1188 model_fields_set fix, and the three items @aminghadersohi already called non-blocking in the thread above). Also rebased onto current master to clear the conflict in `tests/unit_tests/mcp_service/native_tool_inventory.json` — that file is a generated snapshot (`SUPERSET_MCP_UPDATE_TOOL_INVENTORY=1 pytest tests/unit_tests/mcp_service/test_native_tool_surface.py` regenerates it), so I took a placeholder value through the rebase and I'm letting CI's own run confirm whether it needs a real regen; will follow up if that check comes back red. One thread is still genuinely open and not just stale: `FunnelChartConfig.metric` has no `is_metric` validation, unlike `dimension` (which already rejects non-metric columns) and unlike `GaugeChartConfig`/`BigNumberChartConfig`. A bare column with no aggregate silently becomes `SUM(...)`. @gkneighb, worth a look whenever you're back in here — not asking you to block on it if you'd rather leave it for a family-wide follow-up like the other two you and @aminghadersohi already parked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
