justinpark commented on PR #45495: URL: https://github.com/apache/superset/pull/45495#issuecomment-6431056125
Thanks @sadpandajoe, addressed in a880a21: - Hash: now resolved from the layout (the hash target's tab ancestors) instead of `directPathToChild`, and dropped once any of those tabs leaves `active_tabs`, so a tab click no longer keeps it alive. - Added a `DashboardPage` test seeding a stale `directPathToChild`: it's cleared with explicit `active_tabs` and left untouched with a hash or focused chart. - Added a `hydrate` test asserting `['TAB-2', 'TAB-deleted']` is hydrated as `['TAB-2']`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
