rusackas opened a new pull request, #45774:
URL: https://github.com/apache/superset/pull/45774

   ### SUMMARY
   
   `superset/db_engine_specs/base.py`'s `DBEngineSpecMetadata` has a 
`known_incompatibilities` field specifically for warning users when a driver 
doesn't yet support a Superset dependency version. `mysql.py`/`postgres.py` 
(Aurora Data API), `kusto.py`, and `solr.py` already use it to flag their 
respective drivers' lack of SQLAlchemy 2.0 support.
   
   `couchbase.py` had no such entry, despite being in the exact same situation: 
`couchbase-sqlalchemy` hard-pins `sqlalchemy>=1.3.0,<2.0` — verified both on 
PyPI (latest release 1.0.3) and directly against the upstream `main` branch's 
`setup.py` (not yet fixed even unreleased). That's flatly incompatible with 
Superset's `sqlalchemy>=2.0.52,<2.1`, so `pip install` refuses to resolve the 
combination at all. A user trying to add Couchbase support got no warning 
anywhere in Superset's own docs before hitting that failure. An open upstream 
issue already tracks the gap: `couchbase/couchbase-sqlalchemy#3` ("Feature 
Request: Use SQLAlchemy V2").
   
   This PR adds the same `known_incompatibilities` entry shape to 
`couchbase.py`'s metadata.
   
   While in there, re-verified the three existing entries against live upstream 
source (all three still genuinely broken — Aurora Data API's issue is open 
since 2023 with no reply since 2023-02; `sqlalchemy-kusto` still hard-pins 
`sqlalchemy==1.4.*` on `main`; `sqlalchemy-solr` still hard-pins 
`sqlalchemy~=1.4.7`), so bumped their `since` dates to today's recheck date 
rather than leaving them reading `2026-07-28`.
   
   ### TESTING INSTRUCTIONS
   
   ```
   pytest tests/unit_tests/db_engine_specs/test_couchbase.py 
tests/unit_tests/db_engine_specs/test_kusto.py 
tests/unit_tests/db_engine_specs/test_base.py -v
   ```
   194 tests pass. `pre-commit run` (including the `lint_metadata.py --strict` 
metadata-completeness hook) is clean on all four changed files.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to