rusackas commented on code in PR #45774:
URL: https://github.com/apache/superset/pull/45774#discussion_r4403845599
##########
superset/db_engine_specs/couchbase.py:
##########
@@ -114,6 +114,20 @@ class CouchbaseEngineSpec(BasicParametersMixin,
BaseEngineSpec):
"is_recommended": True,
},
],
+ "known_incompatibilities": [
+ {
+ "dependency": "SQLAlchemy 2.0",
+ "reason": (
+ "setup.py on the couchbase-sqlalchemy main branch
hard-pins "
+ "sqlalchemy>=1.3.0,<2.0; pip will refuse to install it "
+ "alongside Superset's sqlalchemy>=2.0.52,<2.1."
Review Comment:
Good catch on both. Reworded to say it downgrades SQLAlchemy to 1.4 and
breaks Superset, and dropped the hard-coded Superset pin so it cannot drift.
Pushed in 8f6b7bb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
