sadpandajoe commented on code in PR #45410: URL: https://github.com/apache/superset/pull/45410#discussion_r4386900424
########## superset/charts/client_processing.py: ########## @@ -78,6 +80,37 @@ # column meta and formatter selection, so it shares this post-processor. AG_GRID_TABLE = "ag-grid-table" +# "Adaptive formatting" in the time format controls, mirroring ``SMART_DATE_ID`` +# in ``superset-ui-core/time-format``. It is an alias the browser resolves to a +# formatter that picks a representation per value, not a format string. +SMART_DATE = "smart_date" Review Comment: `SMART_DATE` is defined here but nothing reads it: `is_strftime_expressible` rejects `smart_date` through the no-directive check, and the test hardcodes the string. The constant and its comment read as if they gate that behavior, so someone changing one would expect the other to follow. Should it be removed, or is it meant to be compared against in `is_strftime_expressible`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
