SEPURI-SAI-KRISHNA commented on code in PR #45410: URL: https://github.com/apache/superset/pull/45410#discussion_r4402832528
########## superset/charts/client_processing.py: ########## @@ -78,6 +80,37 @@ # column meta and formatter selection, so it shares this post-processor. AG_GRID_TABLE = "ag-grid-table" +# "Adaptive formatting" in the time format controls, mirroring ``SMART_DATE_ID`` +# in ``superset-ui-core/time-format``. It is an alias the browser resolves to a +# formatter that picks a representation per value, not a format string. +SMART_DATE = "smart_date" Review Comment: My leftover. I dropped the `time_format != SMART_DATE` comparison earlier in this PR and left the constant behind. Removed, and all 314 stay green without it. Comparing against it instead would put back a branch no test can separate, since the no-directive check already rejects `smart_date`. That is why the comparison went. The explanation stays at the point of rejection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
