codeant-ai-for-open-source[bot] commented on code in PR #45782:
URL: https://github.com/apache/superset/pull/45782#discussion_r4387679521
##########
superset/utils/csv.py:
##########
@@ -107,13 +108,27 @@ def escape_values(v: Any) -> Union[str, Any]:
# even when the DataFrame has a non-default index (e.g. the flattened
# MultiIndex produced by pivot_table_v2 post-processing). Pairing
positional
# indices with the label-based ``.at`` accessor would otherwise create
- # phantom rows and corrupt the output. Only string cells are reassigned, so
- # the dtype of mixed object columns (e.g. nullable integers) is preserved.
+ # phantom rows and corrupt the output. Numeric dtypes are left for pandas;
+ # object columns need explicit formatting to match streaming CSV exports.
+ decimal_separator = kwargs.get("decimal", ".")
for name, column in df.items():
if pd.api.types.is_string_dtype(column.dtype):
for label, value in column.items():
if isinstance(value, str):
df.at[label, name] = escape_value(value)
+ elif isinstance(value, Decimal) and value.is_finite():
+ # Preserve precision and scale without passing numeric text
+ # through the string formula-prefix escaping path.
+ df.at[label, name] = format_decimal(value).replace(
+ ".", decimal_separator
+ )
Review Comment:
**Suggestion:** With duplicate row labels, `.at[label, name]` updates every
matching row, so formatting one Decimal overwrites distinct values and corrupts
the CSV.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b51ec639a2a94857af8f29ed18676eff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b51ec639a2a94857af8f29ed18676eff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/csv.py
**Line:** 122:124
**Comment:**
*Logic Error: With duplicate row labels, `.at[label, name]` updates
every matching row, so formatting one Decimal overwrites distinct values and
corrupts the CSV.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45782&comment_hash=f668d7eb3286f253fd97541861abe43f4f1cbcd541f66c7a7cee826f4d236144&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45782&comment_hash=f668d7eb3286f253fd97541861abe43f4f1cbcd541f66c7a7cee826f4d236144&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
