aminghadersohi commented on code in PR #45782:
URL: https://github.com/apache/superset/pull/45782#discussion_r4437298403
##########
docs/admin_docs/configuration/configuring-superset.mdx:
##########
@@ -145,6 +145,30 @@ D3_TIME_FORMAT = {
Restart Superset after changing `superset_config.py` so the frontend receives
the updated formatter configuration.
+## CSV decimal separators
+
+CSV exports contain data values rather than the chart's D3 display strings.
+Configure the export delimiter and decimal separator independently of the UI
+language in `superset_config.py`, for example:
+
+```python
+CSV_EXPORT = {"encoding": "utf-8-sig", "sep": ";", "decimal": ","}
+```
+
+This writes `12,3400` for a database decimal value of `12.3400` and `1,25` for
+a floating-point value of `1.25`, including numeric cells in mixed object
+columns. Decimal precision and trailing zeros are preserved. Text values
Review Comment:
Nit: Not true for CSV reports of table and pivot table charts or pivoted CSV
exports: `apply_client_processing` re-reads the CSV with `pd.read_csv`, so
`12.3400` is written back as `12.34` (or `12,34`).
```suggestion
columns. Decimal precision and trailing zeros are preserved, except in CSV
reports of table and pivot table charts and in pivoted CSV exports, which
re-read numbers as floats. Text values
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
