codeant-ai-for-open-source[bot] commented on code in PR #45789:
URL: https://github.com/apache/superset/pull/45789#discussion_r4389970899
##########
.github/workflows/superset-python-presto-hive.yml:
##########
@@ -177,7 +177,7 @@ jobs:
- name: Python unit tests (PostgreSQL)
run: |
uv pip install --system -e .[hive]
- ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
+ ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow or
hive_engine_spec'
Review Comment:
**Suggestion:** This selects a test that queries Hive after `up -d` but
never waits for HiveServer2 readiness, so slow startup can make the query fail
intermittently.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Possible bug`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=35da23bff7594f6cbc5f9a44c45e145b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=35da23bff7594f6cbc5f9a44c45e145b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/superset-python-presto-hive.yml
**Line:** 180:180
**Comment:**
*Possible Bug: This selects a test that queries Hive after `up -d` but
never waits for HiveServer2 readiness, so slow startup can make the query fail
intermittently.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45789&comment_hash=5800decb69d59d5d5251135859f7dfa6140c41e884de7430c0977023878e167f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45789&comment_hash=5800decb69d59d5d5251135859f7dfa6140c41e884de7430c0977023878e167f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]