dhruv-techdev commented on PR #45789: URL: https://github.com/apache/superset/pull/45789#issuecomment-6445035604
Hi @sadpandajoe, this is the follow-up for option 3 from your review on #45435 : a test that runs the Hive Week grain expression against the real Hive 2.3.2 in the `test-postgres-hive` CI job. - It runs `HiveEngineSpec`'s actual `WEEK` expression over 14 literal days and checks every day maps to its week's Monday. - It's marked `hive_engine_spec`, and the Hive job now selects that marker. It skips on non-Hive backends. - Locally on Hive 2.3.2 it passes with the current expression and fails with the previous one (e.g. `2025-01-07 → 2025-01-02`). I'll also look into how newer Hive versions handle `'u'` separately, as you mentioned. cc @rusackas since you merged #45435 Could you please review when you have time? Happy to adjust anything. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
