codeant-ai-for-open-source[bot] commented on code in PR #45785:
URL: https://github.com/apache/superset/pull/45785#discussion_r4388752108
##########
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts:
##########
@@ -402,9 +402,14 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
});
}
+ // The summary row is a display feature: a file download keeps one query
so it is one file
+ // (several queries are bundled into a zip).
+ const isFileExport = ['csv', 'xlsx'].includes(formData.result_format ??
'');
+
if (
metrics?.length &&
formData.show_totals &&
+ !isFileExport &&
Review Comment:
**Suggestion:** With `percent_metric_calculation: 'all_records'`, the
earlier denominator query remains, so CSV/XLSX exports still contain multiple
results and are bundled into a zip.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=05e198ed3e5d49eba2760e35e6fa0dd2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=05e198ed3e5d49eba2760e35e6fa0dd2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts
**Line:** 412:412
**Comment:**
*Incomplete Implementation: With `percent_metric_calculation:
'all_records'`, the earlier denominator query remains, so CSV/XLSX exports
still contain multiple results and are bundled into a zip.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45785&comment_hash=48ba3cca90bc9deec12b353a96bab00794b899db7733b66954cf09b23d4ae103&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45785&comment_hash=48ba3cca90bc9deec12b353a96bab00794b899db7733b66954cf09b23d4ae103&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
