codeant-ai-for-open-source[bot] commented on code in PR #45785:
URL: https://github.com/apache/superset/pull/45785#discussion_r4409130984
##########
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts:
##########
@@ -402,9 +402,14 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
});
}
+ // The summary row is a display feature: a file download keeps one query
so it is one file
+ // (several queries are bundled into a zip).
+ const isFileExport = ['csv', 'xlsx'].includes(formData.result_format ??
'');
+
if (
metrics?.length &&
formData.show_totals &&
+ !isFileExport &&
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `7166187`.
Added an `isFileExport` check so the `all_records` denominator query is not
added for CSV/XLSX exports. The totals query is also skipped for file exports,
leaving a single query.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
