sadpandajoe commented on code in PR #45709:
URL: https://github.com/apache/superset/pull/45709#discussion_r4395780199
##########
pyproject.toml:
##########
@@ -92,7 +92,7 @@ dependencies = [
"bottleneck", # recommended performance dependency for pandas, see
https://pandas.pydata.org/docs/getting_started/install.html#performance-dependencies-recommended
# --------------------------
"parsedatetime",
- "paramiko>=3.4.0, <4.0", # 4.0 removed DSSKey, still referenced by
sshtunnel
+ "paramiko>=5.1.0, <6.0", # 4.0 removed DSSKey, still referenced by
sshtunnel
Review Comment:
This floor jump from 3.x to 5.1.0 also drops the legacy algorithms paramiko
3.5.1 still negotiated: `ssh-rsa`/`ssh-dss` host-key and pubkey signatures and
the SHA-1 key-exchange groups are gone from the 5.1.0 defaults in `Transport`.
An existing SSH-tunnel database connection whose bastion only offers an
`ssh-rsa` host key or SHA-1 kex would connect today and fail negotiation after
this upgrade, and `superset/extensions/ssh.py` has no way to re-enable them. Is
that break acceptable here, and should it be called out in UPDATING.md? The
trailing comment about 4.0 removing DSSKey is also no longer the reason for
this pin, since sshtunnel 0.5.1 guards `DSSKey` with `hasattr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
