shubhamjrd4559-sudo opened a new pull request, #45801: URL: https://github.com/apache/superset/pull/45801
### SUMMARY Oracle versions before 12.2 support identifiers up to 30 bytes, while Oracle 12.2 and later support up to 128. Superset currently applies the 128-character engine-spec limit to every Oracle version, which can produce ORA-00972 when generated chart aliases exceed the legacy limit. This change makes the maximum alias length database-aware, uses 30 for Oracle releases before 12.2 and preserves the 128 limit for newer releases, and passes the database context through label generation. Other engine specs keep their existing class-level limit. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. ### TESTING INSTRUCTIONS - Added focused Oracle tests for configured versions before and after 12.2, plus alias truncation behavior. - Run `pytest tests/unit_tests/db_engine_specs/test_oracle.py -q`. - Local pytest could not start because Flask is not installed in this environment; CI results will provide full test validation. ### ADDITIONAL INFORMATION - [x] Has associated issue: References #45758 (Oracle identifier-length follow-up only; nested-AND ROWNUM handling is tracked separately in #45771). - [ ] Required feature flags: None. - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
