shubhamjrd4559-sudo commented on PR #45801: URL: https://github.com/apache/superset/pull/45801#issuecomment-6539592697
Hi @rebenitez1802, thanks for the detailed review. I rebased this PR on the latest master and addressed the reported issues: the shortened series alias lookup, repeated Oracle version lookup failures within a request, and the test mock’s database argument. I’ve added regression tests, and CI is running on the updated commit. I also noticed #45675 covers the same issue—would you prefer I keep this PR open for re-review or close it in favor of #45675? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
