sadpandajoe opened a new pull request, #45824: URL: https://github.com/apache/superset/pull/45824
### SUMMARY The Datasets, Dashboards and Charts list tables render with `tableLayout="auto"`. #37299 pinned the **Name** column to a fixed `xxxl` (360px) to stop layout shift, but left other columns without a `size`. An unsized column gets no `<col>` width, so in auto table layout it absorbs all the spare container width: the Datasets and Dashboards **Actions** column (and Dashboards **Last modified**) stretched to several hundred pixels of mostly-empty space while Name stayed squashed, and the Charts **Type** column became very wide. This gives every visible column on the three list pages an explicit `size`, so spare width is distributed proportionally across all columns: - Datasets: Actions `lg` - Dashboards: Tags, Editors, Viewers, Last modified `xl`; Actions `lg` - Charts: Type `xxl` (bounded), Tags and Viewers `xl` (Actions was already `lg`) `TableCollection` and the `.ant-table-cell` `max-width` rule are unchanged, so Name keeps the layout stability from #37299. Widths remain proportional (not a hard cap), so the Actions column is much narrower but not pixel-identical across pages. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Datasets list at 1920px (same data, viewport and state): ## Before  ## After  Measured widths at 1920px: Datasets Actions 915px -> 201px (Name 360px -> 624px); Dashboards Actions 442px -> 200px (Name 360px -> 620px); Charts Type 556px -> 246px. Dashboards and Charts screenshots (1920 and 1440), the hover state of the Actions icons and the raw metrics are in the [same Gist](https://gist.github.com/sadpandajoe/9adbe3012b3f26639c29b4b92be74545). ### TESTING INSTRUCTIONS 1. Open the Datasets, Dashboards and Charts list pages at a wide viewport (e.g. 1920px) with the default table view. 2. Confirm the Name column is the widest column, the Actions column is narrow, and the Charts Type column is bounded. 3. Hover a row and confirm the Actions icons still appear and are not clipped; hover a long, truncated name and confirm the title tooltip still shows the full name. 4. Enable the `TAGGING_SYSTEM` and `ENABLE_VIEWERS` feature flags and confirm the Tags and Viewers columns are also bounded. 5. Automated: `npm test -- DatasetList.columnSizing DashboardList.columnSizing ChartList.columnSizing TableCollection` (the new tests assert every visible column renders a `<col>` with an explicit width and fail without this change). Pure visual layout cannot be measured in jsdom, which is why it is covered by the screenshots above. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
