codeant-ai-for-open-source[bot] commented on code in PR #45824:
URL: https://github.com/apache/superset/pull/45824#discussion_r4427789625
##########
superset-frontend/src/pages/DatabaseList/index.tsx:
##########
@@ -1042,6 +1043,7 @@ function DatabaseList({
},
Header: t('Actions'),
id: 'actions',
+ layout: 'actions',
Review Comment:
**Suggestion:** On OAuth2 databases, a user with edit, export,
token-management, and delete permissions sees five actions; the 120px preset
clips the last control.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Css layout issue`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=25eee056af804deda06283ff9a2e82ee&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=25eee056af804deda06283ff9a2e82ee&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/pages/DatabaseList/index.tsx
**Line:** 1046:1046
**Comment:**
*Css Layout Issue: On OAuth2 databases, a user with edit, export,
token-management, and delete permissions sees five actions; the 120px preset
clips the last control.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45824&comment_hash=cb9036ea88083b126b93dc9e11c886ebcf3de8e2559db361585d69f8d208fccb&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45824&comment_hash=cb9036ea88083b126b93dc9e11c886ebcf3de8e2559db361585d69f8d208fccb&reaction=dislike'>๐</a>
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx:
##########
@@ -350,8 +448,8 @@ function TableCollection<T extends object>({
size={size}
data-test="listview-table"
pagination={paginationConfig}
- scroll={{ x: 'max-content' }}
- tableLayout="auto"
+ scroll={{ x: columnLayout ? columnLayout.totalWidth : 'max-content' }}
Review Comment:
**Suggestion:** `TableView` does not enable managed widths, but this still
sets `scroll.x` to `'max-content'`, forcing generic tables into horizontal
scrolling and changing their auto-width behavior.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f04b844f9c5e4197ba93d693b104c7ca&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f04b844f9c5e4197ba93d693b104c7ca&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx
**Line:** 451:451
**Comment:**
*Api Mismatch: `TableView` does not enable managed widths, but this
still sets `scroll.x` to `'max-content'`, forcing generic tables into
horizontal scrolling and changing their auto-width behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45824&comment_hash=3744a858d35faee7670c1bfef2a09f2f6dab45801daaccd8fccdd91d2926d6a3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45824&comment_hash=3744a858d35faee7670c1bfef2a09f2f6dab45801daaccd8fccdd91d2926d6a3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
