mikebridge opened a new pull request, #45829: URL: https://github.com/apache/superset/pull/45829
### SUMMARY **TL;DR:** Close the dashboard Version History panel when the dashboard enters edit mode. **Background:** The dashboard editor has its own right-hand sidebar (charts and layout elements). Version History is also a right-hand panel. **Problem:** If Version History was open when a user clicked Edit dashboard, it stayed open next to the editor's sidebar. Two right-side panels at once crowd the editing surface and are confusing. **What this changes:** The Version History host isn't rendered while the dashboard is in edit mode, and its existing cleanup closes the panel state. After leaving edit mode, history can be reopened from the menu as before. The history menu entry was already hidden in edit mode, and the rule that an active version preview blocks editing is unchanged. No new state and no style changes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: Version History stays open beside the editor sidebar after entering edit mode. After: entering edit mode closes Version History; only the editor sidebar shows. No browser screenshots in this pass; a component regression test covers both states. ### TESTING INSTRUCTIONS 1. Enable `VERSION_HISTORY` and open a dashboard you can edit. 2. Open Version History from the dashboard menu, then click Edit dashboard: the history panel closes. 3. Leave edit mode and reopen Version History: it works as before. Automated: `DashboardBuilder`, `DashboardVersionHistory` and `Header` suites. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `VERSION_HISTORY` - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
