mikebridge commented on PR #45829: URL: https://github.com/apache/superset/pull/45829#issuecomment-6515509482
Thanks Amin, you're right. `ON_SAVE` clears `hasUnsavedChanges` and `editMode` in the same reducer return, and `sessionEntries` needs `hasUnsavedChanges`, so those entries aren't reachable right after a save. My earlier comment was wrong on that point. I'd like to keep this PR focused on the panel and restore lifecycle and clean up the unreachable entries separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
