hughhhh opened a new pull request, #45833: URL: https://github.com/apache/superset/pull/45833
### SUMMARY Partition preview messages could describe a throttled request or NULL output as a broken transform, claim an invalid expression was already saved, or omit the next step for a missing placeholder or incompatible output type. This change distinguishes those outcomes, offers an explicit retry for unavailable previews, and moves keyboard focus to the transform input after moving a mapping. It also catches unmatched nested parentheses before warehouse probes and uses readable Hive partition-filter errors in Samples and drill-to-detail. Existing save eligibility, emitted predicates, transform defaults, and cached verdict semantics are preserved. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - HTTP 429: “Filters will not be mirrored” → “Preview temporarily unavailable,” with a Retry button. - NULL output: generic evaluation failure → an explanation that one or more preview values returned NULL. - Move mapping: focus falls off the removed button → focus lands in Value transform. - Hive strict mode: raw `TExecuteStatementResp(...)` → guidance to add a suitable partition filter. ### TESTING INSTRUCTIONS Proof: 642 backend tests and 144 frontend tests pass; staged-file pre-commit checks pass, including mypy and frontend typechecking. Ten new or strengthened backend assertions fail against the unchanged base. Headless Chromium exercised the actual mapping component with controlled HTTP responses and verified focus transfer, accessible placeholder guidance, throttling, and successful retry without page errors. With `PARTITION_FILTER_MAPPING` enabled: 1. Preview `extract(epoch from cast(:value as timestamp)` and `lower(:value), 'x'`: expect syntax guidance without a warehouse probe or a claim that the mapping was saved. 2. Preview NULL-producing and incompatible-type transforms: expect distinct NULL and cast guidance. Enter a nonempty transform without `:value`: expect a nonblocking field warning. 3. Throttle the preview endpoint: expect an unavailable-preview warning, then successful recovery through Retry. 4. Activate “Move mapping to this column” with Enter or Space: continue typing directly in Value transform. 5. On Hive strict mode, open Samples or drill detail without a partition filter: expect a readable error. A working filtered request should still succeed. The Hive driver error shapes are covered by regression tests; a live Hive warehouse was not available for this run. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `PARTITION_FILTER_MAPPING` - [x] Changes UI - [ ] Includes DB Migration - [x] Introduces new feature or API: additive preview diagnostic reason `null_result` - [ ] Removes existing feature or API Reviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved. Created with GPT-6 Astra in T3 Code through the Codex harness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
