geido commented on code in PR #45833:
URL: https://github.com/apache/superset/pull/45833#discussion_r4478179666
##########
superset/views/datasource/utils.py:
##########
@@ -231,7 +231,14 @@ def get_samples( # pylint: disable=too-many-arguments
QueryCacheManager.delete(
count_star_data.get("cache_key"), CacheRegion.DATA
)
- raise DatasetSamplesFailedError(sample_data.get("error") or "")
+ messages = [
+ error["message"]
+ for error in sample_data.get("errors") or []
Review Comment:
I think this needs a look before merge: IIUC `get_df_payload_result` only
puts `error` in the query payload, not `errors`, so this lookup comes back
empty. On a strict-mode Hive 4.0.1 table, Samples still shows the raw
`TExecuteStatementResp(...)`, same as master (video below). The test mocks
`errors` into `get_payload()`, so it can't catch this. Am I missing a path that
sets it?
https://github.com/user-attachments/assets/89a7a66a-187e-4517-bd08-644b93b15b96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
