villebro commented on a change in pull request #8733: Replace pandas.DataFrame
with PyArrow.Table for nullable int typing
URL:
https://github.com/apache/incubator-superset/pull/8733#discussion_r359014891
##########
File path: superset/sql_lab.py
##########
@@ -278,14 +279,17 @@ def _serialize_and_expand_data(
):
data = (
pa.default_serialization_context()
- .serialize(cdf.raw_df)
+ .serialize(result_table.pa_table)
.to_buffer()
.to_pybytes()
)
+
# expand when loading data from results backend
all_columns, expanded_columns = (selected_columns, [])
else:
- data = cdf.data or []
+ df = result_table.to_pandas_df()
+ data = df_to_dict(df) or []
Review comment:
shouldn't this be `df_to_dict(df) or {}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
