villebro commented on a change in pull request #8733: Replace pandas.DataFrame
with PyArrow.Table for nullable int typing
URL:
https://github.com/apache/incubator-superset/pull/8733#discussion_r359014355
##########
File path: superset/sql_lab.py
##########
@@ -264,12 +265,12 @@ def _serialize_payload(
def _serialize_and_expand_data(
- cdf: SupersetDataFrame,
+ result_table: SupersetTable,
db_engine_spec: BaseEngineSpec,
use_msgpack: Optional[bool] = False,
expand_data: bool = False,
) -> Tuple[Union[bytes, str], list, list, list]:
- selected_columns: list = cdf.columns or []
+ selected_columns: list = result_table.columns
expanded_columns: list
Review comment:
nit: I'm guessing these are `List[str]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
