eschutho opened a new pull request, #45853: URL: https://github.com/apache/superset/pull/45853
### What After a user finishes signing in through the "Authorization needed" link, the original tab (for example a dashboard) now reloads its data automatically, instead of leaving the message on screen until a manual page refresh. ### Why The sign-in tab used to notify the original tab through the browser's "opener" link between the two tabs. That link is dropped when the login provider's pages restrict it, and then the original tab never hears that sign-in finished. Also, the listener in the original tab was torn down and recreated every time the dashboard's chart state changed, which could make it miss the message. ### How - The sign-in completion page now announces success through a same-origin broadcast channel, with a browser-storage notification as a fallback (this matches what is already on `master`). - The listener in `OAuth2RedirectMessage` is set up once per sign-in request and reads the latest dashboard/chart state when the message arrives; it acts only once even if both signals arrive. - Explore charts that are not yet saved also re-run correctly. ### Testing - Rewrote `OAuth2RedirectMessage.test.tsx` to cover broadcast and storage signals, dashboards whose charts change while waiting, duplicate signals, wrong tab IDs, and the case where the channel cannot be created. - Not run locally (frontend dependencies were not installed in my environment); relying on CI. - Not tested end to end against a real Snowflake account. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
