FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-6509530063
### Summary of Review Feedback Resolutions
All inline review threads and follow-ups have been resolved and verified
across the test suite:
1. **Databricks Specifications & Dependency Alignment**:
- `DatabricksNativeEngineSpec`: updated metadata to reference
`pypi_packages: ['apache-superset[databricks]']` to match modern install
recommendations and avoid legacy `databricks-dbapi` dependency conflicts.
- `DatabricksODBCEngineSpec` & `DatabricksHiveEngineSpec`: clarified
driver packages (`databricks-dbapi[odbc]`, `pyodbc` and
`databricks-dbapi[hive]`, `pyhive`, `thrift`) and added explicit
`known_incompatibilities` documenting SQLAlchemy 2.0 limitations with upstream
tracking links.
- Preserved `connect_args` schema retention and URL synchronization in
native spec.
2. **Dialect Metadata Hardening**:
- **ClickHouse**: explicitly configured `sqlalchemy_docs_url` on
`ClickHouseConnectEngineSpec` pointing to ClickHouse Connect documentation
(`https://clickhouse.com/docs/en/integrations/sql-clients/superset`),
preventing legacy driver URL fallback through inheritance.
- **IBM i**: corrected the `database` URI parameter label to explicitly
document "RDB name" rather than library/schema.
- **Parseable**: aligned default port 8000 with `parseable+http://` while
retaining `parseable+https://` in connection examples.
- **Aurora PostgreSQL**: verified `"default_port": 5432` in Data API
metadata, ensuring `build_sqlalchemy_uri` resolves default ports without
raising `KeyError`.
3. **AST Linter & Test Isolation**:
- Updated `get_all_engine_specs_ast` in `lint_metadata.py` to scan past
bare annotations without initializers (e.g., `engine: str` followed by `engine
= "..."`) without prematurely stopping discovery.
- Isolated `test_lint_metadata.py` using pytest `tmp_path` fixtures and
monkeypatched `SPECS_DIR`, completely eliminating temp file creation in the
source package directory.
cc @sadpandajoe @rusackas @villebro for final review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
