FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-6520212204
@sadpandajoe Thank you for the detailed review. All items have been
addressed in the latest commit:
1. **Databricks No-Catalog Reflection (Comment 4418792300)**: Avoided
forcing `catalog` on the connection handshake (which breaks clusters without
multi-catalog support) while preventing `DESCRIBE TABLE EXTENDED
\`None\`.\`default\`.\`orders\`` during reflection.
`DatabricksNativeEngineSpec.get_columns` and `get_table_names` now resolve
`dialect.catalog` dynamically via `SHOW CATALOGS` / `SELECT current_catalog()`
if unset prior to reflection. Added
`test_databricks_native_get_columns_resolves_no_catalog_reflection`.
2. **Catalog Switching vs Server Default Schema Reset (Comment
4401559032)**: `adjust_engine_params` now checks `catalog !=
server_default_catalog` when no catalog is configured on the connection,
ensuring genuine catalog switches reset schema to `"default"` while the server
default retains the configured schema. Added unit test asserting genuine
switches away from unconfigured catalog.
3. **URI Schema Fallback Test Coverage (Comment 4418791833)**: Added unit
test pinning `or uri.query.get("schema")` fallback in `adjust_engine_params`
when `connect_args` schema is omitted.
4. **AST Tuple Unit Test Fixture (Comment 4406914059)**: Added `"pair":
("value", -1)` fixture to
`tests/unit_tests/db_engine_specs/test_lint_metadata.py` to assert `ast.Tuple`
evaluation.
5. **ClickHouse Connect Live Documentation URLs (Comment 4418791826)**:
Updated `sqlalchemy_docs_url` and `docs_url` to the live guide
`https://clickhouse.com/docs/integrations/connectors/data-visualization/superset-and-clickhouse`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
