codeant-ai-for-open-source[bot] commented on code in PR #45867:
URL: https://github.com/apache/superset/pull/45867#discussion_r4419349958
##########
superset/charts/data/api.py:
##########
@@ -699,6 +700,18 @@ def _get_data_response(
QueryObjectValidationError,
) as exc:
return
self.response_400(message=sanitize_error_message(exc.message))
+ except DBAPIError:
Review Comment:
**Suggestion:** `async_mode` requests take `_run_async` before reaching this
handler, so a connection failure during its cache lookup still escapes as an
unhandled 500.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f83a2f1a5bff4e5a9fc4016726f972b4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f83a2f1a5bff4e5a9fc4016726f972b4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/data/api.py
**Line:** 703:703
**Comment:**
*Incomplete Implementation: `async_mode` requests take `_run_async`
before reaching this handler, so a connection failure during its cache lookup
still escapes as an unhandled 500.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45867&comment_hash=963fcdd11a0c0cb77f15ef87496800cad7e68aeaf0d2cf0341d2aa6016b3834a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45867&comment_hash=963fcdd11a0c0cb77f15ef87496800cad7e68aeaf0d2cf0341d2aa6016b3834a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
