codeant-ai-for-open-source[bot] commented on code in PR #45890:
URL: https://github.com/apache/superset/pull/45890#discussion_r4423700072
##########
superset/utils/json.py:
##########
@@ -362,6 +367,32 @@ def get_masked_fields(
return masked
+def unrevealable_masked_fields(
+ old_payload: dict[str, Any] | None,
+ new_payload: dict[str, Any],
+ sensitive_fields: set[str],
+) -> list[str]:
+ """
+ Returns masked fields in ``new_payload`` that ``old_payload`` cannot
reveal.
+
+ :func:`reveal_sensitive` swaps a mask back for the stored value at the same
+ path. Where the stored payload has no value there, the mask would be kept
and
+ stored as if it were the secret, so callers that must not do that (imports
+ overwriting a connection) use this to ask for the real value instead.
+
+ :param old_payload: The stored payload, if any
+ :param new_payload: The incoming payload, possibly containing masks
+ :param sensitive_fields: The set of fields to check, as JSONPath
expressions
+ :returns: JSONPath expressions for masked fields with nothing to reveal
+ """
+ return [
+ field
+ for field in get_masked_fields(new_payload, sensitive_fields)
+ if old_payload is None
+ or not any(match.value for match in parse(field).find(old_payload))
Review Comment:
**Suggestion:** Stored `0` or `False` values are treated as missing, so
imports reject masks even though `reveal_sensitive` can restore those values.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Falsy zero check`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9171ed4c08f146a18bcce5c287d45a85&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9171ed4c08f146a18bcce5c287d45a85&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/json.py
**Line:** 391:392
**Comment:**
*Falsy Zero Check: Stored `0` or `False` values are treated as missing,
so imports reject masks even though `reveal_sensitive` can restore those values.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45890&comment_hash=0917c7a72843073e3e1579e420082c6bc86e4ef55bd7ef15002add84ca3daca7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45890&comment_hash=0917c7a72843073e3e1579e420082c6bc86e4ef55bd7ef15002add84ca3daca7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
