codeant-ai-for-open-source[bot] commented on code in PR #45890:
URL: https://github.com/apache/superset/pull/45890#discussion_r4423718009
##########
superset/commands/database/importers/v1/utils.py:
##########
@@ -190,6 +191,25 @@ def import_database( # noqa: C901
else:
config["encrypted_extra"] = masked_encrypted_extra
+ # Never store a mask as if it were the secret: the schema asks for any
+ # value that cannot be revealed, so one left here is a bug, not input.
+ engine_spec = (
+ existing.db_engine_spec
+ if existing
+ else get_engine_spec(
+ make_url_safe(config["sqlalchemy_uri"]).get_backend_name(),
+
driver=make_url_safe(config["sqlalchemy_uri"]).get_driver_name(),
+ )
+ )
Review Comment:
**Suggestion:** When an overwrite changes engines, this checks only the
existing engine's secret paths; a mask for the new engine is missed and stored
as the credential.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect variable
usage`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=181af71845c24de59e362c8c2706e818&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=181af71845c24de59e362c8c2706e818&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/database/importers/v1/utils.py
**Line:** 196:203
**Comment:**
*Incorrect Variable Usage: When an overwrite changes engines, this
checks only the existing engine's secret paths; a mask for the new engine is
missed and stored as the credential.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45890&comment_hash=7dd8ef54c7c6bf7c11ed1ec97602cd799491b8d1fb25cbdd575a6b91e0203c99&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45890&comment_hash=7dd8ef54c7c6bf7c11ed1ec97602cd799491b8d1fb25cbdd575a6b91e0203c99&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
