codeant-ai-for-open-source[bot] commented on code in PR #45895:
URL: https://github.com/apache/superset/pull/45895#discussion_r4426571604
##########
superset/semantic_layers/models.py:
##########
@@ -905,6 +905,23 @@ def get_extra_cache_keys(self, query_obj: QueryObjectDict)
-> list[Hashable]:
keys: list[Hashable] = [self.metadata_generation,
"semantic-null-filters-v1"]
if discriminator is not None:
keys.append(("semantic-result-version", *discriminator))
+
+ from superset import is_feature_enabled
+
+ if is_feature_enabled("CACHE_QUERY_BY_USER"):
+ try:
+ from superset.semantic_layers.execution import (
+ current_host_execution_context,
+ )
+
+ exec_context = current_host_execution_context()
+ if not exec_context.is_guest and exec_context.identity_digest:
+ keys.append(("semantic-user",
exec_context.identity_digest))
+ except Exception as ex:
+ logger.debug(
+ "Could not resolve semantic execution context for cache:
%s", ex
+ )
Review Comment:
**Suggestion:** When `CACHE_QUERY_BY_USER` is enabled, any context-building
failure is swallowed and these keys lack a user discriminator, so cache lookup
can return another user's semantic results.
**Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=79ca87e478084394bbcd6e713eeeece2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=79ca87e478084394bbcd6e713eeeece2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 920:923
**Comment:**
*Security: When `CACHE_QUERY_BY_USER` is enabled, any context-building
failure is swallowed and these keys lack a user discriminator, so cache lookup
can return another user's semantic results.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45895&comment_hash=91a654b5cb5ef8c6ab2d27ece230aa1be98e51f2507bee32000d39f5430d9b88&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45895&comment_hash=91a654b5cb5ef8c6ab2d27ece230aa1be98e51f2507bee32000d39f5430d9b88&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
