FrancescoCastaldi commented on PR #45895:
URL: https://github.com/apache/superset/pull/45895#issuecomment-6541382989
### PR Remediation & Coverage Hardening Update
1. **Reviewer Thread Addressed (Thread 4426571604)**:
- Addressed review finding regarding error handling under
`CACHE_QUERY_BY_USER`.
- When `CACHE_QUERY_BY_USER` is enabled and execution context resolution
encounters an unexpected failure, `SemanticView.get_extra_cache_keys()` now
logs a warning and appends a distinct uncacheable nonce
`("semantic-user-unresolved", uuid.uuid4().hex)`.
- This ensures fail-safe user isolation so that context resolution
failures never collapse into a shared cache key or leak semantic results across
users.
2. **Test Coverage & CI Remediation**:
- Added unit test in `tests/unit_tests/semantic_layers/models_test.py`
exercising the exception fallback branch and verifying that successive
unresolved context resolutions produce unique cache keys.
- All 167 unit tests pass cleanly, closing the missing coverage on lines
920-924 in `superset/semantic_layers/models.py` and satisfying the strict 100%
module coverage requirement (`--cov-fail-under=100`).
- Linting and formatting audited and verified with Ruff (`<= 88` columns).
3. **Commit & Push**:
- Amended commit `3895a3a996` with DCO sign-off pushed to
`origin/fix/issue-45877-semantic-view-cache-query-by-user`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
