Aleem89 commented on PR #45648:
URL: https://github.com/apache/superset/pull/45648#issuecomment-6540187916
Thanks @EnxDev , the fixes for 4 out of 5 of the points you mentioned are in
a92eaf6:
- Marker opacity: each drawn part now carries its own value (line = series
opacity, symbol = marker opacity) instead of nesting inside the SVG, so shifted
markers are back at 0.7 like Scroll.
Screenshot below.
- Vertical offset: dropped the fixed 3px and centered the icon on its
label instead; it was actually sitting about 2.5px low before. The pin's head
overflows its box, so the entry list keeps that much room under the sticky
selector row, derived from the pin geometry.
- Hidden markers: covered in the icon tests now.
- Transparent-line comment: reworded.
On the theme overrides: agreed, the HTML legend has never seen the ECharts
option overrides (that predates this PR, from #43314), and plumbing the merged
legend options into it is a bigger change. This would probably fit better in
its own PR, which I'd be happy to do in the next few days if agreed.
<img width="1294" height="510" alt="legend-final-opacity"
src="https://github.com/user-attachments/assets/c9379817-34a6-44a7-a508-ca40f036d185";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
